Conversation
0654239 to
2dbfd60
Compare
2dbfd60 to
0fc2cd9
Compare
lcovar
left a comment
There was a problem hiding this comment.
the wasm functions use .unwrap() which will crash on bad input - wasm-solana and wasm-utxo both return Result<T, Error> instead, can you match that pattern?
|
also validate inputs before processing - bad data (wrong size keys, empty arrays, invalid party_id) will panic instead of returning an error |
dd91a86 to
ad68856
Compare
You must be looking at the Rust test. The actual functions that are wasm-bound return proper Result types.
I don't think this is the case. I added some unit tests that show the code does not panic with bad inputs. |
615a29c to
befc2e8
Compare
|
pls change commit and title to |
befc2e8 to
a239009
Compare
a239009 to
fd5adb9
Compare
so are these part of the interface or only used in tests? |
fd5adb9 to
7f140e2
Compare
7f140e2 to
0493f92
Compare
f7a9a64 to
3deec7f
Compare
3deec7f to
9af9527
Compare
9af9527 to
2732ced
Compare
a710c12 to
8739f8f
Compare
Ticket: HSM-1425
8739f8f to
9029386
Compare
| @@ -0,0 +1,55 @@ | |||
| { | |||
There was a problem hiding this comment.
There's no name or description property for this module. I think these are needed to publish it. here's an example
Ticket: HSM-1425