Skip to content

Comments

feat: add wasm-mps#170

Merged
johnoliverdriscoll merged 1 commit intomasterfrom
sl-mps
Feb 20, 2026
Merged

feat: add wasm-mps#170
johnoliverdriscoll merged 1 commit intomasterfrom
sl-mps

Conversation

@johnoliverdriscoll
Copy link
Contributor

Ticket: HSM-1425

@johnoliverdriscoll johnoliverdriscoll force-pushed the sl-mps branch 4 times, most recently from 0654239 to 2dbfd60 Compare February 19, 2026 22:15
@johnoliverdriscoll johnoliverdriscoll marked this pull request as ready for review February 19, 2026 22:25
@johnoliverdriscoll johnoliverdriscoll requested a review from a team as a code owner February 19, 2026 22:25
Copy link
Contributor

@lcovar lcovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wasm functions use .unwrap() which will crash on bad input - wasm-solana and wasm-utxo both return Result<T, Error> instead, can you match that pattern?

@lcovar
Copy link
Contributor

lcovar commented Feb 19, 2026

also validate inputs before processing - bad data (wrong size keys, empty arrays, invalid party_id) will panic instead of returning an error

@johnoliverdriscoll johnoliverdriscoll force-pushed the sl-mps branch 2 times, most recently from dd91a86 to ad68856 Compare February 20, 2026 00:27
@johnoliverdriscoll
Copy link
Contributor Author

the wasm functions use .unwrap() which will crash on bad input - wasm-solana and wasm-utxo both return Result<T, Error> instead, can you match that pattern?

You must be looking at the Rust test. The actual functions that are wasm-bound return proper Result types.

also validate inputs before processing - bad data (wrong size keys, empty arrays, invalid party_id) will panic instead of returning an error

I don't think this is the case. I added some unit tests that show the code does not panic with bad inputs.

@OttoAllmendinger
Copy link
Contributor

pls change commit and title to wasm-mps

@OttoAllmendinger
Copy link
Contributor

the wasm functions use .unwrap() which will crash on bad input - wasm-solana and wasm-utxo both return Result<T, Error> instead, can you match that pattern?

You must be looking at the Rust test. The actual functions that are wasm-bound return proper Result types.

also validate inputs before processing - bad data (wrong size keys, empty arrays, invalid party_id) will panic instead of returning an error

I don't think this is the case. I added some unit tests that show the code does not panic with bad inputs.

so are these part of the interface or only used in tests?

@johnoliverdriscoll johnoliverdriscoll force-pushed the sl-mps branch 3 times, most recently from a710c12 to 8739f8f Compare February 20, 2026 15:05
@johnoliverdriscoll johnoliverdriscoll merged commit 74f2f80 into master Feb 20, 2026
7 checks passed
@johnoliverdriscoll johnoliverdriscoll deleted the sl-mps branch February 20, 2026 16:22
@@ -0,0 +1,55 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no name or description property for this module. I think these are needed to publish it. here's an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants